-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds short format to timestamp_t #4376
Merged
thinkyhead
merged 4 commits into
MarlinFirmware:RCBugFix
from
jbrazio:timestamp_t-short
Jul 23, 2016
Merged
Adds short format to timestamp_t #4376
thinkyhead
merged 4 commits into
MarlinFirmware:RCBugFix
from
jbrazio:timestamp_t-short
Jul 23, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrazio
force-pushed
the
timestamp_t-short
branch
from
July 23, 2016 02:05
871a519
to
9e5dbf6
Compare
#endif | ||
#ifndef MSG_INFO_COMPLETED_PRINTS | ||
#define MSG_INFO_COMPLETED_PRINTS "Completed" | ||
#endif | ||
#ifndef MSG_INFO_PRINT_TIME | ||
#define MSG_INFO_PRINT_TIME "Duration " | ||
#define MSG_INFO_PRINT_TIME "Total" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These strings were padded to align their values and give a cleaner appearance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The padding is now on the LCD display code which makes much more sense.
silvio-didonna
added a commit
to silvio-didonna/Marlin
that referenced
this pull request
Jul 24, 2016
Closed
CONSULitAS
pushed a commit
to CONSULitAS/Marlin-K8200
that referenced
this pull request
Aug 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #4371 (comment), also follows up #4312 by adding longest job and extruded filament stats to the menu.
@MarlinFirmware/language-team new strings available !