Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds short format to timestamp_t #4376

Merged
merged 4 commits into from
Jul 23, 2016

Conversation

jbrazio
Copy link
Contributor

@jbrazio jbrazio commented Jul 23, 2016

Follow up #4371 (comment), also follows up #4312 by adding longest job and extruded filament stats to the menu.

@MarlinFirmware/language-team new strings available !

@jbrazio jbrazio added this to the 1.1.0 milestone Jul 23, 2016
@jbrazio jbrazio force-pushed the timestamp_t-short branch from 871a519 to 9e5dbf6 Compare July 23, 2016 02:05
#endif
#ifndef MSG_INFO_COMPLETED_PRINTS
#define MSG_INFO_COMPLETED_PRINTS "Completed"
#endif
#ifndef MSG_INFO_PRINT_TIME
#define MSG_INFO_PRINT_TIME "Duration "
#define MSG_INFO_PRINT_TIME "Total"
Copy link
Member

@thinkyhead thinkyhead Jul 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These strings were padded to align their values and give a cleaner appearance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The padding is now on the LCD display code which makes much more sense.

@thinkyhead thinkyhead merged commit 1766b99 into MarlinFirmware:RCBugFix Jul 23, 2016
@jbrazio jbrazio deleted the timestamp_t-short branch July 23, 2016 19:27
@thinkyhead thinkyhead mentioned this pull request Jul 25, 2016
CONSULitAS pushed a commit to CONSULitAS/Marlin-K8200 that referenced this pull request Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants