-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for R.D.F.G.S.C. with MEGATRONICS 3 board #4445
Fix for R.D.F.G.S.C. with MEGATRONICS 3 board #4445
Conversation
The support for reprapworld LCD boke the code for the REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER. See Full Grapics Display does not work any more after MarlinFirmware#4408 MarlinFirmware#4439
003be14
to
83d0d59
Compare
The same is needed for Minitronics |
@Blue-Marlin Oh yes?? Can we also further add support for the RDFGSC (because currently the Minitronics pins defines all its LCD pins as -1). Do we know whether the same pins will work for this unit as for the Megatronics 3? Also, do you think we should define these other pins in all cases? : #define BLEN_C 2
#define BLEN_B 1
#define BLEN_A 0 At one point I recall (maybe only in |
I have no clue, but the structural changes, for Minitronics, in #4408 have been the same. As far i can see the BLEN_? definitions can be removed from the Configs. They are defined as well in |
Yes indeed. Actually, the ultralcd headers are a little convoluted concerning these bits. I'm trying to sort them out so there's no unnecessary redundancy. |
97daace
to
925e439
Compare
925e439
to
a6cfad0
Compare
a6cfad0
to
03fdb26
Compare
Rebase, cleanup of #4441, addressing #4439
When #4408 added support for RepRapWorld LCD, it improperly overrode the pins for other LCDs like the
REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
. This PR restores those pin definitions.