Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for R.D.F.G.S.C. with MEGATRONICS 3 board #4445

Merged
merged 5 commits into from
Jul 28, 2016

Conversation

thinkyhead
Copy link
Member

Rebase, cleanup of #4441, addressing #4439

When #4408 added support for RepRapWorld LCD, it improperly overrode the pins for other LCDs like the REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER. This PR restores those pin definitions.

The support for reprapworld LCD boke the code for the REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER. See Full Grapics Display does not work any more after MarlinFirmware#4408  MarlinFirmware#4439
@thinkyhead thinkyhead force-pushed the rc_fix_rdfgsc_mega3 branch from 003be14 to 83d0d59 Compare July 28, 2016 20:12
@Blue-Marlin
Copy link
Contributor

Blue-Marlin commented Jul 28, 2016

The same is needed for Minitronics

@thinkyhead
Copy link
Member Author

thinkyhead commented Jul 28, 2016

@Blue-Marlin Oh yes?? Can we also further add support for the RDFGSC (because currently the Minitronics pins defines all its LCD pins as -1). Do we know whether the same pins will work for this unit as for the Megatronics 3?

Also, do you think we should define these other pins in all cases? :

  #define BLEN_C 2
  #define BLEN_B 1
  #define BLEN_A 0

At one point I recall (maybe only in dev?) moving the definitions for these three out of the pins files, because they are always defined as 0, 1, 2.

@Blue-Marlin
Copy link
Contributor

Blue-Marlin commented Jul 28, 2016

I have no clue, but the structural changes, for Minitronics, in #4408 have been the same.

As far i can see the BLEN_? definitions can be removed from the Configs. They are defined as well in ultralcd_implementation_hitachi_HD44780.h as indogm_lcd_implementation.h for all ULTIPANEL aka panels that can handle a menu because they have an input device.

@thinkyhead
Copy link
Member Author

the BLEN_? definitions can be removed from the Configs

Yes indeed. Actually, the ultralcd headers are a little convoluted concerning these bits. I'm trying to sort them out so there's no unnecessary redundancy.

@thinkyhead thinkyhead force-pushed the rc_fix_rdfgsc_mega3 branch from 97daace to 925e439 Compare July 28, 2016 21:38
@thinkyhead thinkyhead force-pushed the rc_fix_rdfgsc_mega3 branch from 925e439 to a6cfad0 Compare July 28, 2016 21:39
@thinkyhead thinkyhead force-pushed the rc_fix_rdfgsc_mega3 branch from a6cfad0 to 03fdb26 Compare July 28, 2016 21:44
@thinkyhead thinkyhead merged commit ae1c7bc into MarlinFirmware:RCBugFix Jul 28, 2016
@thinkyhead thinkyhead deleted the rc_fix_rdfgsc_mega3 branch July 28, 2016 22:55
@jbrazio jbrazio modified the milestone: 1.1.0 Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants