Save bytes for custom chars (Hitachi LCD) #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
rc_lcd_chars_save_ram
branch
from
f1391f2 to
4292753
Compare
|
I've confirmed that debris of previous content has been solved. But I found that new bug? introduced by this PR?. |
Great!
Aha, yes, I did make a change that's causing "Card removed/inserted" to appear at boot. I'll have a patch for that shortly. |
ghost
mentioned this pull request
thinkyhead
added a commit
that referenced
this pull request
Oct 22, 2016
Fix for the PR #4553 (Save bytes for custom chars (Hitachi LCD))
Closed
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
May 31, 2024
…ntry Add Shutdown host to LCD Menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding
staticto the custom characters they take only half as much space in the binary.There's also an issue where the LCD fails to clear when switching screens. This PR attempts to address that by explicitly clearing the screen rather than relying on the draw flag.