Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yml: Randomly map postgres db port #2000

Merged
merged 1 commit into from
May 20, 2022
Merged

Update docker-compose.yml: Randomly map postgres db port #2000

merged 1 commit into from
May 20, 2022

Conversation

RNHTTR
Copy link
Contributor

@RNHTTR RNHTTR commented May 20, 2022

Signed-off-by: Ryan Hatter [email protected]

Problem

Overriding default postgres port 5432 when running Marquez alongside other applications that use port 5432

Closes: #1956

Solution

Update docker-compose.yml to randomly map postgres db port

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2000 (e234c53) into main (3fbe2f9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2000   +/-   ##
=========================================
  Coverage     78.23%   78.23%           
  Complexity      955      955           
=========================================
  Files           194      194           
  Lines          5293     5293           
  Branches        420      420           
=========================================
  Hits           4141     4141           
  Misses          706      706           
  Partials        446      446           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit ac7a455 into MarquezProject:main May 20, 2022
Copy link
Collaborator

@rossturk rossturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@collado-mike
Copy link
Collaborator

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose non-default port for Postgres in docker/up.sh
4 participants