Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null column type in column-lineage #2272

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

pawel-big-lebowski
Copy link
Collaborator

Signed-off-by: Pawel Leszczynski [email protected]

Problem

Column lineage endpoint throw an exception when no data type of the field provided.

Closes: #2261

Solution

Write a test for this scenario, allow null.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the api API layer changes label Dec 1, 2022
@pawel-big-lebowski pawel-big-lebowski changed the title allow nullable column type in column-lineaeg Allow null column type in column-lineaege Dec 1, 2022
@pawel-big-lebowski pawel-big-lebowski changed the title Allow null column type in column-lineaege Allow null column type in column-lineage Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #2272 (a14140b) into main (36e94ce) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2272      +/-   ##
============================================
+ Coverage     76.82%   76.84%   +0.01%     
  Complexity     1154     1154              
============================================
  Files           220      220              
  Lines          5268     5268              
  Branches        423      423              
============================================
+ Hits           4047     4048       +1     
  Misses          747      747              
+ Partials        474      473       -1     
Impacted Files Coverage Δ
...arquez/db/mappers/ColumnLineageNodeDataMapper.java 90.47% <100.00%> (ø)
api/src/main/java/marquez/common/Utils.java 88.66% <0.00%> (+0.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pawel-big-lebowski pawel-big-lebowski merged commit 0dea573 into main Dec 1, 2022
@pawel-big-lebowski pawel-big-lebowski deleted the fix-nullable-column-type branch December 1, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marquez should allow a field with no datatype
3 participants