Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused filter on RunDao.updateStartState() #2319

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

wslulciuc
Copy link
Member

Problem

RunDao.updateStartState() requires that updated_at < transitionedAt or, start_run_state_uuid != null; it's unclear of the reasoning and the conditions don't allow for updating the run state as expected.

Solution

Remove conditions: updated_at < transitionedAt and start_run_state_uuid != null

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@wslulciuc wslulciuc requested a review from fm100 December 14, 2022 00:35
@boring-cyborg boring-cyborg bot added the api API layer changes label Dec 14, 2022
@wslulciuc wslulciuc added the review Ready for review label Dec 14, 2022
@wslulciuc wslulciuc enabled auto-merge (squash) December 14, 2022 00:35
@wslulciuc wslulciuc merged commit 78725b1 into main Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #2319 (bd552a5) into main (f66007e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2319   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1177     1177           
=========================================
  Files           222      222           
  Lines          5354     5354           
  Branches        429      429           
=========================================
  Hits           4108     4108           
  Misses          768      768           
  Partials        478      478           
Impacted Files Coverage Δ
api/src/main/java/marquez/db/RunDao.java 92.50% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc deleted the bug/update-run-state-cond branch December 14, 2022 00:35
@wslulciuc wslulciuc removed the review Ready for review label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants