-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OL facets - PR3 - migrate data to facet tables #2359
Merged
wslulciuc
merged 1 commit into
ol-facets/PR2-read-data-from-views
from
ol-facets/PR3-data-migration-to-facet-tables
Jan 31, 2023
Merged
OL facets - PR3 - migrate data to facet tables #2359
wslulciuc
merged 1 commit into
ol-facets/PR2-read-data-from-views
from
ol-facets/PR3-data-migration-to-facet-tables
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-big-lebowski
force-pushed
the
ol-facets/PR2-read-data-from-views
branch
4 times, most recently
from
January 13, 2023 13:29
0d322ef
to
bde93bd
Compare
pawel-big-lebowski
force-pushed
the
ol-facets/PR3-data-migration-to-facet-tables
branch
from
January 13, 2023 13:59
117fdba
to
846437a
Compare
Codecov Report
@@ Coverage Diff @@
## ol-facets/PR2-read-data-from-views #2359 +/- ##
========================================================================
+ Coverage 76.85% 77.11% +0.26%
- Complexity 1208 1234 +26
========================================================================
Files 227 228 +1
Lines 5495 5572 +77
Branches 444 447 +3
========================================================================
+ Hits 4223 4297 +74
- Misses 774 775 +1
- Partials 498 500 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pawel-big-lebowski
force-pushed
the
ol-facets/PR3-data-migration-to-facet-tables
branch
from
January 16, 2023 13:59
846437a
to
951d60a
Compare
pawel-big-lebowski
force-pushed
the
ol-facets/PR3-data-migration-to-facet-tables
branch
from
January 17, 2023 07:22
951d60a
to
b84b4b0
Compare
Closed
7 tasks
pawel-big-lebowski
force-pushed
the
ol-facets/PR2-read-data-from-views
branch
6 times, most recently
from
January 19, 2023 08:50
80116ab
to
1d1fec4
Compare
pawel-big-lebowski
force-pushed
the
ol-facets/PR3-data-migration-to-facet-tables
branch
from
January 19, 2023 09:10
b84b4b0
to
83929cd
Compare
wslulciuc
reviewed
Jan 26, 2023
wslulciuc
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise 🚀 💯
pawel-big-lebowski
force-pushed
the
ol-facets/PR2-read-data-from-views
branch
from
January 26, 2023 08:28
1d1fec4
to
5967b0c
Compare
pawel-big-lebowski
force-pushed
the
ol-facets/PR3-data-migration-to-facet-tables
branch
2 times, most recently
from
January 26, 2023 09:32
d77e6f4
to
8c69e78
Compare
pawel-big-lebowski
force-pushed
the
ol-facets/PR2-read-data-from-views
branch
2 times, most recently
from
January 27, 2023 07:07
298b4e1
to
b4b1903
Compare
Signed-off-by: Pawel Leszczynski <[email protected]>
pawel-big-lebowski
force-pushed
the
ol-facets/PR3-data-migration-to-facet-tables
branch
from
January 27, 2023 13:30
8c69e78
to
98435c5
Compare
wslulciuc
added a commit
that referenced
this pull request
Jan 31, 2023
#2355) * OL facets - PR2 - read facets from views pointing to lineage_events table Signed-off-by: Pawel Leszczynski <[email protected]> * OL facets - PR3 - migrate data to facet tables (#2359) Signed-off-by: Pawel Leszczynski <[email protected]> --------- Signed-off-by: Pawel Leszczynski <[email protected]> Co-authored-by: Willy Lulciuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawel Leszczynski [email protected]
Problem
The last PR of Openlineage facets' PRs. It contains a migration that backfills newly created facets' tables (
job_facets
,dataset_facets
andrun_facets
) with data contained withinlineage_events
tables. The migration has to be done manually for users with more than 100K lineage_events stored in Marquez.Closes: #ISSUE-NUMBER
Solution
migration_lock
to be able to pause/continue migration and know if it has finished.job_facets_vew
,dataset_facets_view
andrun_facets_view
to point at newly created tables. This will make application logic make use of new tables.Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)