Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase namespace length to 1024 character #2554

Merged
merged 4 commits into from
Jul 27, 2023
Merged

increase namespace length to 1024 character #2554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08588aa
increase namespace length to 1024 character
hloombaupgrade Jul 27, 2023
2f2bdec
test case validation
hloombaupgrade Jul 27, 2023
11407e5
test case validation miss
hloombaupgrade Jul 27, 2023
c959fda
push bug
hloombaupgrade Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/python/marquez_client/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def check_name_length(variable_value, variable_name):
# ['namespace_name', 'owner_name', 'source_name'] <= 64
# ['dataset_name', 'field_name', 'job_name', 'tag_name'] <= 255
if variable_name in ['namespace_name', 'owner_name', 'source_name']:
if len(variable_value) > 64:
if len(variable_value) > 1024:
raise ValueError(f"{variable_name} length is"
f" {len(variable_value)}, must be <= 64")
else:
Expand Down
6 changes: 3 additions & 3 deletions clients/python/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,13 @@ def test_is_none():

def test_check_name_length():
with pytest.raises(ValueError):
Utils.check_name_length(variable_value='a'*65,
Utils.check_name_length(variable_value='a'*1025,
variable_name='namespace_name')
with pytest.raises(ValueError):
Utils.check_name_length(variable_value='a'*65,
Utils.check_name_length(variable_value='a'*1025,
variable_name='owner_name')
with pytest.raises(ValueError):
Utils.check_name_length(variable_value='a'*65,
Utils.check_name_length(variable_value='a'*1026,
variable_name='source_name')
with pytest.raises(ValueError):
Utils.check_name_length(variable_value='a'*256,
Expand Down
Loading