-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal/pagination #2559
Proposal/pagination #2559
Conversation
…o content Signed-off-by: Nisarg-Chokshi <[email protected]>
…content Signed-off-by: Nisarg-Chokshi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2559 +/- ##
=========================================
Coverage 83.26% 83.26%
Complexity 1286 1286
=========================================
Files 243 243
Lines 5934 5934
Branches 279 279
=========================================
Hits 4941 4941
Misses 846 846
Partials 147 147 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
web/src/routes/events/Events.tsx
Outdated
{events.length === 0 ? ( | ||
<></> | ||
) : ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use the &&
notation here since you want to return a null value instead of an empty logical tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phixMe I've added a new commit addressing the change! Could you please have a quick review of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Signed-off-by: Nisarg-Chokshi <[email protected]>
50c2cc9
to
81abe21
Compare
Problem
👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:
Solution
Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.
One-line summary: Updated Dataset & Event route render to remove pagination in case of no content
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)Snapshots