Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Empty Search Experience #2679

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fixes Empty Search Experience #2679

merged 1 commit into from
Nov 8, 2023

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Nov 7, 2023

Problem

We previously had an issue where we were using the previous search value for our search function which was resulting in a bad request for the first character. This was due to the fact we were using a value from an async setState operation immediately after it's set.

image
Error is gone from screenshot.

@boring-cyborg boring-cyborg bot added the web label Nov 7, 2023
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit f42df05
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/654a8d2396376900080c10d6

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2679 (f42df05) into main (752ac23) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2679   +/-   ##
=========================================
  Coverage     83.76%   83.76%           
  Complexity     1338     1338           
=========================================
  Files           247      247           
  Lines          6112     6112           
  Branches        281      281           
=========================================
  Hits           5120     5120           
  Misses          843      843           
  Partials        149      149           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@phixMe phixMe requested a review from wslulciuc November 7, 2023 19:25
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phixMe! 💯 🥇

@wslulciuc wslulciuc merged commit 3cd3419 into main Nov 8, 2023
16 checks passed
@wslulciuc wslulciuc deleted the fix/stale-and-empty-search branch November 8, 2023 17:06
@wslulciuc wslulciuc added this to the 0.43.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants