-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dataset schema versions #2763
feat: add dataset schema versions #2763
Conversation
✅ Deploy Preview for peppy-sprite-186812 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2d26f95
to
7961d23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
============================================
+ Coverage 84.56% 84.74% +0.18%
- Complexity 1441 1456 +15
============================================
Files 251 253 +2
Lines 6504 6562 +58
Branches 303 305 +2
============================================
+ Hits 5500 5561 +61
+ Misses 851 850 -1
+ Partials 153 151 -2 ☔ View full report in Codecov by Sentry. |
7961d23
to
d70a405
Compare
d70a405
to
a176fc5
Compare
api/src/main/java/marquez/db/models/ExtendedDatasetVersionRow.java
Outdated
Show resolved
Hide resolved
df73ec0
to
ffbe1aa
Compare
Next step with this is to look at the deprecated |
ffbe1aa
to
b6bcdac
Compare
Signed-off-by: David Goss <[email protected]>
Signed-off-by: David Goss <[email protected]>
Signed-off-by: David Goss <[email protected]>
Signed-off-by: David Goss <[email protected]>
242d636
to
fe9c905
Compare
Signed-off-by: David Goss <[email protected]>
Signed-off-by: David Goss <[email protected]>
Signed-off-by: David Goss <[email protected]>
This should be suitable to merge and release, so we start writing data into the new tables now, which should ease the migration later. Next steps in this project will be (in no particular order and can be in parallel):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 💯 💯
Problem
This PR is the first step towards implementing the proposal from https://github.com/MarquezProject/marquez/blob/main/proposals/2676-version-dataset-schemas-separately.md.
Solution
The idea is that, without changing what already gets written to the database, we start writing to the new
dataset_schema_versions
anddataset_schema_versions_field_mapping
tables.Todo
DatasetDao
code pathLegacynot viable to tackle in this PRRunDao
code pathHandle input dataset where schema doesn't match current versionfor now will not change schema version even when input dataset schema has drifted - to be discussed in Handling of input datasets where schema different from current version #2764One-line summary: Add dataset schema versions to model and start writing to it
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)