Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jobVersion field to Run in Java client #2808

Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 4, 2024

Problem

The Java client for the getRun method currently does not include the jobVersion in the response DTO.

Solution

This PR adds jobVersion to the Run class so it can be successfully deserialised and accessed by consumers.

One-line summary: Add jobVersion field to Run in Java client

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Copy link

netlify bot commented May 4, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 3314885
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/663983bb4c7377000873b62b

@davidjgoss davidjgoss force-pushed the feature/client-java-run-job branch from 0bc383f to 25788f6 Compare May 4, 2024 11:08
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (f1eabc4) to head (25788f6).

❗ Current head 25788f6 differs from pull request most recent head 3314885. Consider uploading reports for the commit 3314885 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2808   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
- Complexity     1429     1430    +1     
=========================================
  Files           251      251           
  Lines          6460     6462    +2     
  Branches        299      299           
=========================================
+ Hits           5457     5459    +2     
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

@wslulciuc wslulciuc enabled auto-merge (squash) May 7, 2024 01:28
@wslulciuc wslulciuc merged commit 5cd14e8 into MarquezProject:main May 7, 2024
15 checks passed
@davidjgoss davidjgoss deleted the feature/client-java-run-job branch May 7, 2024 05:14
@wslulciuc wslulciuc added this to the 0.47.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants