-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add common labels to replicasets #2877
Conversation
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
=========================================
Coverage 83.28% 83.28%
Complexity 1477 1477
=========================================
Files 259 259
Lines 6785 6785
Branches 313 313
=========================================
Hits 5651 5651
Misses 977 977
Partials 157 157 ☔ View full report in Codecov by Sentry. |
b1eaf7b
to
946f706
Compare
a547d62
to
c4df215
Compare
09bc5a8
to
d2fb0c0
Compare
Signed-off-by: Isa Inalcik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 🥇
Great job! Congrats on your first merged pull request in the Marquez project! |
Problem
Replicasets were missing common labels. This PR adds them to deployments.
Solution
Replicasets were missing common labels. This PR adds them to deployments.
One-line summary:
Replicasets were missing common labels. This PR adds them to deployments.