Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common labels to replicasets #2877

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

alaturqua
Copy link
Contributor

Problem

Replicasets were missing common labels. This PR adds them to deployments.

Solution

Replicasets were missing common labels. This PR adds them to deployments.

One-line summary:
Replicasets were missing common labels. This PR adds them to deployments.

@boring-cyborg boring-cyborg bot added the chart label Aug 21, 2024
Copy link

boring-cyborg bot commented Aug 21, 2024

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 4940763
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66c8b0439dce5d0009c00fd4

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (88cc969) to head (4940763).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2877   +/-   ##
=========================================
  Coverage     83.28%   83.28%           
  Complexity     1477     1477           
=========================================
  Files           259      259           
  Lines          6785     6785           
  Branches        313      313           
=========================================
  Hits           5651     5651           
  Misses          977      977           
  Partials        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alaturqua alaturqua reopened this Aug 21, 2024
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🥇

@wslulciuc wslulciuc added this to the 0.50.0 milestone Aug 23, 2024
@wslulciuc wslulciuc enabled auto-merge (squash) August 23, 2024 15:52
@wslulciuc wslulciuc merged commit 915aff3 into MarquezProject:main Aug 23, 2024
16 checks passed
Copy link

boring-cyborg bot commented Aug 23, 2024

Great job! Congrats on your first merged pull request in the Marquez project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants