feat: Refactor database handling for analyzer logic (#1423)

commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/GitHubCommit.java

@@ -1,28 +1,18 @@
 package io.github.martinwitt.laughing_train.domain.entity;
 
 import java.io.Serializable;
-import java.time.LocalDateTime;
-import java.util.ArrayList;
-import java.util.Comparator;
-import java.util.List;
+import java.util.Objects;
 
 public class GitHubCommit implements Serializable {
 
   private String commitHash;
-  private List<AnalyzerStatus> analyzerStatuses;
 
   public GitHubCommit() {
-    analyzerStatuses = new ArrayList<>();
     // for JPA
   }
 
-  /**
-   * @param commitHash
-   * @param analyzerStatuses
-   */
-  public GitHubCommit(String commitHash, List<AnalyzerStatus> analyzerStatuses) {
+  public GitHubCommit(String commitHash) {
     this.commitHash = commitHash;
-    this.analyzerStatuses = analyzerStatuses;
   }
 
   /**
@@ -39,34 +29,21 @@ public void setCommitHash(String commitHash) {
     this.commitHash = commitHash;
   }
 
-  /**
-   * @return the analyzerStatuses
-   */
-  public List<AnalyzerStatus> getAnalyzerStatuses() {
-    return analyzerStatuses;
+  @Override
+  public boolean equals(Object o) {
+    if (this == o) return true;
+    if (o == null || getClass() != o.getClass()) return false;
+    GitHubCommit that = (GitHubCommit) o;
+    return Objects.equals(commitHash, that.commitHash);
   }
 
-  /**
-   * @param analyzerStatuses the analyzerStatuses to set
-   */
-  public void setAnalyzerStatuses(List<AnalyzerStatus> analyzerStatuses) {
-    this.analyzerStatuses = analyzerStatuses;
+  @Override
+  public int hashCode() {
+    return Objects.hash(commitHash);
   }
 
-  public void addAnalyzerStatus(AnalyzerStatus analyzerStatus) {
-    analyzerStatuses.stream()
-        .filter(v -> v.getCommitHash().equals(analyzerStatus.getCommitHash()))
-        .filter(v -> v.getAnalyzerName().equals(analyzerStatus.getAnalyzerName()))
-        .findFirst()
-        .ifPresentOrElse(
-            v -> {
-              analyzerStatuses.remove(v);
-              analyzerStatuses.add(analyzerStatus);
-            },
-            () -> analyzerStatuses.add(analyzerStatus));
-    if (analyzerStatuses.size() > 10) {
-      analyzerStatuses.sort(Comparator.comparing(v -> LocalDateTime.parse(v.getLocalDateTime())));
-      analyzerStatuses.removeFirst();
-    }
+  @Override
+  public String toString() {
+    return "GitHubCommit{" + "commitHash='" + commitHash + '\'' + '}';
   }
 }

commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/RemoteProject.java

@@ -42,31 +42,19 @@ public void addCommitHash(GitHubCommit commit) {
     commits.add(commit);
   }
 
-  /**
-   * (non-Javadoc)
-   *
-   * @see Object#hashCode()
-   */
   @Override
-  public int hashCode() {
-    return Objects.hash(projectName, projectUrl);
+  public boolean equals(Object obj) {
+    if (this == obj) return true;
+    if (obj == null || getClass() != obj.getClass()) return false;
+    RemoteProject that = (RemoteProject) obj;
+    return Objects.equals(projectName, that.projectName)
+        && Objects.equals(projectUrl, that.projectUrl)
+        && Objects.equals(commits, that.commits);
   }
 
-  /**
-   * (non-Javadoc)
-   *
-   * @see Object#equals(Object)
-   */
   @Override
-  public boolean equals(Object obj) {
-    if (this == obj) {
-      return true;
-    }
-    if (obj instanceof RemoteProject project) {
-      return Objects.equals(projectName, project.projectName)
-          && Objects.equals(projectUrl, project.projectUrl);
-    }
-    return false;
+  public int hashCode() {
+    return Objects.hash(projectName, projectUrl, commits);
   }
 
   public RemoteProject withProjectUrl(String projectUrl) {

frontend/src/ProjectData.tsx

@@ -8,21 +8,14 @@ export const fetchProjectQuery = gql`
       projectName
       projectUrl
       commits {
-        analyzerStatuses {
-          analyzerName
-          commitHash
-          localDateTime
-          numberOfIssues
-          status
-        }
         commitHash
       }
     }
   }
 `;
 export const recentAnalyzerRuns = gql`
   query recentAnalyzerRuns {
-    recentAnalyzerRuns(size: 30) {
+    recentRuns(size: 30) {
       analyzerName
       commitHash
       numberOfIssues
@@ -105,17 +98,3 @@ export function filterDuplicateBadSmells(params: BadSmell[]) {
   );
 }
 
-export const getGitHubCommitsQuery = gql`
-  query getGitHubCommitsForProject($projectName: String!) {
-    getGitHubCommitsForProject(projectName: $projectName) {
-      analyzerStatuses {
-        analyzerName
-        commitHash
-        localDateTime
-        numberOfIssues
-        status
-      }
-      commitHash
-    }
-  }
-`;