Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor database handling for analyzer logic #1423

Merged
merged 8 commits into from
Jan 5, 2024

Conversation

MartinWitt
Copy link
Owner

No description provided.

Removed redundant code and improved database encodings to ensure accurate tracking of analysis results. This update simplifies the interaction with stored analysis data and improves the overall performance of fetching and writing entries. The GitHubCommit object was simplified to only hold relevant commit information without unnecessarily related entities. Also, Unidirectional relationships were implemented to fit more aligned with new design.
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Field may be 'final' 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

The commit primarily refactors the AnalyzerRun component and associated tests, MiningGraphQLTest, and updates how recentRuns are tested. Equality methods and hashCode functions are added or adapted for AnalyzerRun and other related entities like GitHubCommit and RemoteProject. Also, some unused imports are removed and code re-ordering is made for cleaner organization.
The commit removes all GraphQL queries, types, and components related to AnalyzerStatus. This includes updates in frontend ProjectData.tsx and graphql-types.ts. The query recentAnalyzerRuns has also been renamed to recentRuns.
Copy link

gitstream-cm bot commented Jan 5, 2024

This PR is 26.202090592334493% new code.

@MartinWitt MartinWitt merged commit 43efc59 into master Jan 5, 2024
8 of 10 checks passed
@MartinWitt MartinWitt deleted the feat/AnalyzerStatus branch January 5, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant