Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): 🐛 Improve commit message for single badsmell PRs #767

Merged
merged 1 commit into from
Jun 24, 2023
Merged

fix(git): 🐛 Improve commit message for single badsmell PRs #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions github-bot/src/main/java/io/github/martinwitt/laughing_train/services/RefactorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,20 @@ private void createCommit(GHRepository repo, Path dir, List<? extends Change> ch

private String createCommitMessage(List<? extends Change> changes) {
StringBuilder message = new StringBuilder();
message.append("Refactor bad smells:\n");
changes.stream().map(Change::getBadSmell).distinct().forEach(v -> message.append("- ")
.append(v.getName().asText())
.append("\n")
.append(v.getDescription().asText())
.append("\n"));
if (changes.stream().map(v -> v.getBadSmell()).distinct().count() == 1) {
message.append("Refactor bad smell ")
.append(changes.get(0).getBadSmell().getName().asText())
.append("\n\n")
.append(changes.get(0).getBadSmell().getDescription().asText());

} else {
message.append("Refactor bad smells ")
.append(changes.stream()
.map(v -> v.getBadSmell().getName().asText())
.distinct()
.collect(Collectors.joining(", ")))
.append("\n");
}
return message.toString();
}

Expand Down