Skip to content

feat: Update project and analyzer run data models (#1316)

Sign in for the full log view
GitHub Actions / Qodana Community for JVM completed Dec 8, 2023 in 0s

126 new problems found by Qodana Community for JVM

Qodana Community for JVM

126 new problems were found

Inspection name Severity Problems
Field may be 'final' 🔶 Warning 50
Unchecked warning 🔶 Warning 13
Redundant type cast 🔶 Warning 6
Redundant call to 'String.format()' 🔶 Warning 6
Redundant local variable 🔶 Warning 6
Javadoc declaration problems 🔶 Warning 5
Declaration has problems in Javadoc references 🔶 Warning 5
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 4
Nullability and data flow problems 🔶 Warning 3
Statement with empty body 🔶 Warning 3
Unnecessarily escaped character 🔶 Warning 3
Use of Optional.ofNullable with null or not-null argument 🔶 Warning 2
Stream API call chain can be simplified 🔶 Warning 2
Redundant 'Collection.addAll()' call 🔶 Warning 1
Constant values 🔶 Warning 1
Default annotation parameter value 🔶 Warning 1
Deprecated member is still used 🔶 Warning 1
Double negation 🔶 Warning 1
Field can be local 🔶 Warning 1
Result of method call ignored 🔶 Warning 1
Inner class may be 'static' 🔶 Warning 1
Optional.get() is called without isPresent() check 🔶 Warning 1
Redundant 'File' instance creation 🔶 Warning 1
Labeled switch rule has redundant code block 🔶 Warning 1
Minimum 'switch' branches 🔶 Warning 1
Call to 'printStackTrace()' 🔶 Warning 1
Redundant 'if' statement 🔶 Warning 1
Unnecessary semicolon 🔶 Warning 1
Method can be extracted ◽️ Notice 2
Commented out code ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 21 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/formatting/GoogleStyle.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant 'Collection.addAll()' call 

'addAll()' call can be replaced with parametrized constructor call

Check notice on line 58 in github-bot/src/main/java/io/github/martinwitt/laughing_train/mining/MiningStartup.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Commented out code 

Commented out code (2 lines)

Check warning on line 133 in github-bot/src/main/java/io/github/martinwitt/laughing_train/summary/PeriodicSummary.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values 

Condition `result == null` is always `false`

Check warning on line 94 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Argument `url` might be null

Check warning on line 22 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/config/ConfigStore.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Method invocation `getPath` may produce `NullPointerException`

Check warning on line 72 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/PointlessBooleanExpression.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems 

Method invocation `equals` may produce `NullPointerException`

Check warning on line 41 in github-bot/src/main/java/io/github/martinwitt/laughing_train/summary/PeriodicSummary.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Default annotation parameter value 

Redundant default parameter value assignment

Check warning on line 290 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Deprecated member is still used 

Deprecated member 'withRemoveResultDir' is still used

Check warning on line 45 in spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/array_can_be_replaced_with_enum_values/ArrayCanBeReplacedWithEnumValuesAnalyzer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Double negation 

Double negation in `!(declaration.getEnumValues().size() != count)`

Check warning on line 156 in code-transformation/src/main/java/spoon/reflect/visitor/ImportAnalyzer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Statement with empty body 

`if` statement has empty body

Check warning on line 49 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/transformations/self/LambdaToExecutableReference.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Statement with empty body 

`if` statement has empty body

Check warning on line 300 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Statement with empty body 

`if` statement has empty body

Check notice on line 174 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/spoon/ImportCleaner.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Method can be extracted 

It's possible to extract method returning 'typeRef' from a long surrounding method

Check notice on line 58 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/rules/ProtectedMemberInFinalClass.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Method can be extracted 

It's possible to extract method returning 'change' from a long surrounding method

Check warning on line 38 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaRefactor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field can be local 

Field can be converted to a local variable

Check warning on line 37 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/TransformationEngine.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `processors` may be 'final'

Check warning on line 17 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/config/ConfigStore.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `property` may be 'final'

Check warning on line 48 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `resultFolder` may be 'final'

Check warning on line 17 in spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/badsmells/private_final_method/PrivateFinalMethodAnalyzer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `filter` may be 'final'

Check warning on line 14 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/history/Change.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `issue` may be 'final'

Check warning on line 15 in github-bot/src/main/java/io/github/martinwitt/laughing_train/api/graphql/dto/AnalyzerRunGraphQlDto.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `commitHash` may be 'final'

Check warning on line 18 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/SpoonRefactor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `ruleParser` may be 'final'

Check warning on line 20 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/PositionScanner.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `endLine` may be 'final'

Check warning on line 49 in code-transformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/qodana/QodanaAnalyzer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `qodanaImageName` may be 'final'

Check warning on line 13 in commons/src/main/java/io/github/martinwitt/laughing_train/domain/entity/RemoteProject.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Field may be 'final' 

Field `commits` may be 'final'
View more details on GitHub Actions