feat/improve-root-cert-support #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we're potentially dealing with self-signed root certificate. This is a slight tweak based on a deeper reading of RFC 5280 Section 4.2.1.1 and 4.2.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks certificate revocation check logic to also look for a key identifier in the Subject Key Identifier extension if a key identifier is missing in Authority Key Identifier extension.
This was born out of #302, which I maintain was due to a malformed root certificate. However, while investigating that issue I came to the conclusion, after reading Section 4.2.1.1 and Section 4.2.1.1 of RFC 5280, that my code didn't correctly handle the case of a self-signed root certificate being able to omit an Authority Key Identifier extension but conveying a
keyIdentifiervia the Subject Key Identifier extension instead.