Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): ignore import("node:crypto") by webpack #518

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix(server): ignore import("node:crypto") by webpack #518

merged 2 commits into from
Feb 9, 2024

Conversation

balazsorban44
Copy link
Contributor

Fixes #517

@MasterKale
Copy link
Owner

This fix to support Next.js's Edge runtime was identified here:

#517 (comment)

@MasterKale MasterKale added the package:server @simplewebauthn/server label Feb 8, 2024
@MasterKale MasterKale added this to the v9.0.2 milestone Feb 8, 2024
MasterKale
MasterKale approved these changes Feb 8, 2024
View reviewed changes
Copy link
Owner

@MasterKale MasterKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, I'll merge this and cut a release tonight 🚀

@MasterKale MasterKale merged commit 3037a46 into MasterKale:master Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterKale MasterKale MasterKale approved these changes

Assignees
No one assigned
Labels
package:server @simplewebauthn/server
Projects
None yet
Milestone
v9.0.2
Development

Successfully merging this pull request may close these issues.

ignore node:crypto import with webpack in @simplewebauthn/server
2 participants
@balazsorban44 @MasterKale