Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated GitHub actions #118

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Feb 7, 2023

This pull request addresses potential warnings about the migration of GitHub actions from nodejs:12 to nodejs:16.

Like

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2,
actions/setup-python@v2, codecov/codecov-action@v1. 
For more information see: 
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Fixes issue with missing Python 3.6 on ubuntu:latest (see actions/runner-images#6399).

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 92.91% // Head: 92.73% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (c1003e2) compared to base (0343272).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   92.91%   92.73%   -0.18%     
==========================================
  Files          34       34              
  Lines        1143     1143              
  Branches      166      166              
==========================================
- Hits         1062     1060       -2     
- Misses         59       60       +1     
- Partials       22       23       +1     
Impacted Files Coverage Δ
src/cobald/daemon/runners/trio_runner.py 94.64% <0.00%> (-3.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxfischer2781
Copy link
Member

Do you need to make any more changes to this? I'm fine with merging this otherwise.

@giffels
Copy link
Member Author

giffels commented Feb 16, 2023

No. Please, merge.

@maxfischer2781 maxfischer2781 merged commit 9eed470 into MatterMiners:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants