Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses conditional exports to define the CommonJS and ES module paths for each variant. This enables modern Node versions to load the
.mjs
files, instead of the CommonJS.js
builds.As explained in the documentation, this will prevent consumers from using anything that is not defined by
exports
, so they will no longer be to do e.g.require("web-streams-polyfill/dist/polyfill.js")
. This is likely a breaking change.Moreover, consumers may already be using
import streams from "web-streams-polyfill"
with modern Node, which would give them the CommonJS module as a default export. This will also break, since the default export will be replaced by named exports. Consumers will need to change their code to eitherimport { ReadableStream } ...
orimport * as streams ...
instead.To do: