Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to command, open file, enable logging pref #1

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

dimateos
Copy link

Hey! Nice work on the updates. I had to do some tweaks so I leave them here in case you are interested:

  • "True" "False" booleans in the command were not valid, either use lowercase or cast to interested. Default values were being used instead, there were warnings in the log.
  • In my case, decomp.obj was being saved to the blender.exe directory and then get_last_generated_file_path() was not finding it. I just used the same command to set cd beforhand. I picked data_path from preferences, this ensures a global path.
  • I added a preference to activate VHACD logging messages.

Thanks

@Maxiriton Maxiriton merged commit a72c5f1 into Maxiriton:master Dec 4, 2023
@Maxiriton
Copy link
Owner

Hey Dimateos,

For some reason I didn't get the notification for you pull request.
Seems great to me, thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants