Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move templates to embedded files #51

Merged

Conversation

mimatache
Copy link
Contributor

fixes #49

@mimatache mimatache changed the title feat: move templates to imbedded files feat: move templates to embedded files Nov 10, 2023
@mimatache mimatache force-pushed the feat/move-templates-to-embed-files branch from 9e5ba84 to d123f99 Compare November 10, 2023 19:37
Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great improvement on using the embed and templ packages

@Melkeydev
Copy link
Owner

Great PR - however there are some conflicts that need to be resolved :*(

@mimatache mimatache force-pushed the feat/move-templates-to-embed-files branch from d123f99 to 01ba983 Compare November 12, 2023 00:11
@mimatache
Copy link
Contributor Author

@Melkeydev rebased the PR on main and moved the changed files to the embedded files.

@mimatache mimatache force-pushed the feat/move-templates-to-embed-files branch from 01ba983 to fb4710b Compare November 12, 2023 18:45
@Melkeydev Melkeydev merged commit 43228a4 into Melkeydev:main Nov 12, 2023
stgonzales pushed a commit to stgonzales/go-blueprint that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Move template strings to separate files.
2 participants