-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PullRequestDiffsStream
as child to PullRequestsStream
#345
feat: add PullRequestDiffsStream
as child to PullRequestsStream
#345
Conversation
Thanks @angelachenn! Can you fix the linting issues? I'll review after that. |
Thanks for the quick reply!! Looking into that right now |
63d545f
to
25f4dc5
Compare
pre-commit.ci autofix |
09f843d
to
cd2e81a
Compare
498537b
to
43cabe0
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @angelachenn!
This PR adds a child stream for pull request diffs to the parent pull requests stream. References Parent-Child Streams and Github REST API documentation.
pull_id
to the PR stream parent context, making{org, repo, repo_id, pull_number, pull_id}
. Gives users more flexibility in using or joining their tables.Some clarity on the error catching: all of them are related to the diff size being too large for to process and/or stream.
406
,422
and502
are all from the Github REST API's end.406
beingdiff too large
either because it exceeds the max # of files (300) or lines changed (20000)422
being server error becausediff is taking too long to generate
502
Server ErrorPRs that cause those errors are skipped. I've tested with a pipeline on my end and it all seems to be working successfully.
My initial brute-force approach was just to shove another call to the diff in the
post_process
method withinPullRequestsStreams
based on a config setting, but that results in getting instantly rate-limited lol.Please advise if I missed anything. Thanks!