Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix via column #103

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix via column #103

merged 1 commit into from
Sep 12, 2024

Conversation

daviesgeek
Copy link
Contributor

No description provided.

kevinelliott
kevinelliott approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@kevinelliott kevinelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One thing to consider is that via only is available under specific circumstances (and I believe we may end up just wanting to drop that entirely at some point). Something to think about or review.

@kevinelliott kevinelliott merged commit 593a9c0 into develop Sep 12, 2024
2 checks passed
@kevinelliott kevinelliott deleted the 2024-09-10-chat-via-fixes branch September 12, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinelliott kevinelliott kevinelliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviesgeek @kevinelliott