Correctly identify and throw on unsupported mpc case #1005
Merged
+149
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix conditional cast in TypeCollector This was throwing NRE when the cast failed rather than a more helpful `InvalidCastException`. We can't support late bound types in an AOT environment. Or at least it would be rather involved to do so. Move the mpc test input into a new location where we can unit test the UnionResolver without impacting mpc input. Fixes MessagePack-CSharp#1002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix conditional cast in TypeCollector
This was throwing NRE when the cast failed rather than a more helpful
InvalidCastException.We can't support late bound types in an AOT environment. Or at least it would be rather involved to do so.
Move the mpc test input into a new location where we can unit test the UnionResolver without impacting mpc input.
Fixes #1002