-
-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpc - add externalIgnoreTypeNames feature #1019
Conversation
@neuecc, @AArnott how is this used?
Does print
but I do not see any external ignores listed from
and still get
|
@NoxMortem It looks like you're using 2.1, but this change went into 2.2. Can you upgrade your tool? |
Edit: Sorry. Mea Culpa. I can confirm it is working now. Confirmed with:
I might have forgotten to specify the type correctly. This is working.
And it works. It is important to use
|
@NoxMortem passing the path to an msbuild project instead of the path to a directory will allow mpc to be much more tolerant to any c# syntax and still generate valid C# files. |
For example Cysharp/Ulid#12
when third-party library provides external resolver, mpc should ignore there types.
I've added
string[]? externalIgnoreTypeNames
parameter that can set ignore type from mpc.