New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some source generator issues #1921

Merged

AArnott merged 2 commits into MessagePack-CSharp:develop from AlanLiu90:Branch_develop_FixSGIssues2

Aug 6, 2024

Contributor

AlanLiu90 commented Aug 6, 2024

Fix two issues:

Source generator generates incorrect code for List<SubObject>[] in resolver:
1 => new MsgPack::Formatters.ArrayFormatter<global::System.Collections.Generic.List<T>>(),
Generated resolver can't be used in CompositeResolverAttribute in the same assembly

AlanLiu90 added 2 commits

August 6, 2024 19:22


          Fix an issue about incorrect generic type in source generated resolver

dba1590


          Fix an issue about using source generated resolver with source genera…

c41ee6c

…ted composite resolver in the same assembly

AArnott added this to the v3.0 milestone

AArnott mentioned this pull request

[CompositeResolverAttribute] not yet that useful #1920

Closed

AArnott approved these changes

View reviewed changes

Collaborator

AArnott left a comment

Fantastic. Thank you very much!

AArnott merged commit 3ea9234 into MessagePack-CSharp:develop

4 of 5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet