Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle undefined versioningStrategy #60

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

legobeat
Copy link
Contributor

If the file exists without this field, it gets incorrectly intepreted as "null". This expands the fallback fixed to cover that scenario, and adds an is-file-check to silence an error.

@legobeat legobeat requested a review from a team as a code owner December 13, 2022 04:29
@legobeat legobeat force-pushed the handle-undefined-release-strategy branch from 8036eac to cdc64b5 Compare December 14, 2022 00:01
@legobeat legobeat force-pushed the handle-undefined-release-strategy branch from cdc64b5 to 0184637 Compare December 14, 2022 04:07
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@legobeat legobeat merged commit f485824 into MetaMask:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants