List package versions in releases for monorepos with independent versioning #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the notes for a monorepo release lists all of the packages that are included in that release, but does not list the versions of those packages that are being published. This makes reviewing past releases difficult as we have to cross-reference package tags with monorepo tags to determine those versions. This commit fixes that. For instance, instead of seeing the following for a GitHub release: > # 59.0.0 > > ## @metamask/base-controller > > (release notes for base-controller) > > ## @metamask/controller-utils > > (release notes for controller-utils) we should now see: > # 59.0.0 > > ## @metamask/base-controller 4.0.0 > > (release notes for base-controller) > > ## @metamask/controller-utils 5.0.0 > > (release notes for controller-utils)
Mrtenz
reviewed
Jun 23, 2023
mcmire
changed the title
|
Looks great! CI still failing though |
This reverts commit c6815ab.
|
I've fixed CI on this PR: #80 |
|
I've tested this on a monorepo with independent versions ( |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the notes for a independently-versioned monorepo release lists all of the packages that are included in that release, but does not list the versions of those packages that are being published. This makes reviewing past releases difficult as we have to cross-reference package tags with monorepo tags to determine those versions.
This commit fixes that. For instance, instead of seeing the following for a GitHub release:
we should now see: