fix: skip packages with version 0.0.0 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
skip-packages-with-version-zero
branch
4 times, most recently
from
42bc835 to
fd02a27
Compare
When adding a new package to a monorepo, this script will fail unless the new package is included in the next release. It sees the initial version of `0.0.0` as "new" because it doesn't match the version on npm (which does not exist). The script has been updated to skip packages with the version `0.0.0` to better accommodate this scenario.
Gudahtt
force-pushed
the
skip-packages-with-version-zero
branch
from
fd02a27 to
a15ee72
Compare
Gudahtt
commented
Sep 28, 2023
| @@ -39,7 +39,7 @@ jobs: | |||
| while read -r location name; do | |||
| if [[ "$name" != "root" ]]; then | |||
| PRIVATE=$(jq --raw-output '.private' "$location/package.json") | |||
| if [[ "$PRIVATE" != true && "${#PUBLIC_PACKAGES[@]}" -ne 3 ]]; then | |||
| if [[ "$PRIVATE" != true && "${#PUBLIC_PACKAGES[@]}" -ne 4 ]]; then | |||
There was a problem hiding this comment.
This part of the test selects a few packages to modify in the next step. We used to only need 3, but I've upped it to 4 because I've added a new test case (the 0.0.0 case)
|
Verified. I get the following output. No polling controller |
Mrtenz
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new package to a monorepo, this script will fail unless the new package is included in the next release. It sees the initial version of
0.0.0as "new" because it doesn't match the version on npm (which does not exist).The script has been updated to skip packages with the version
0.0.0to better accommodate this scenario.The test has been updated to include an example demonstrating this behavior
To manually test this:
get-release-packages.shscriptGITHUB_OUTPUTunbound variable error)