-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump snaps packages #21255
Bump snaps packages #21255
Conversation
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
610cdc9
to
a0b7b2d
Compare
Builds ready [a499bb1]
Page Load Metrics (897 ± 468 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21255 +/- ##
========================================
Coverage 68.64% 68.64%
========================================
Files 1017 1017
Lines 40797 40797
Branches 10893 10893
========================================
Hits 28004 28004
Misses 12793 12793
☔ View full report in Codecov by Sentry. |
@SocketSecurity ignore @metamask/[email protected] We own these and they are published, not sure why Socket can't find them. |
@@ -4791,6 +4808,34 @@ __metadata: | |||
languageName: node | |||
linkType: hard | |||
|
|||
"@metamask/snaps-controllers@npm:^3.0.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected and accepted that we now use two different instances of snaps-controllers
and thereby two distinct versions of snaps-execution-environment
?
Old version is still used through @metamask/keyring-api
and @metamask/eth-snap-keyring
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the keyring-api
, it was updated on version 1.0.0-rc.1
(pending approval to publish), and once it's released, I'll update the eth-snap-keyring
too.
This should be part of #21246, which is stacked over this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this should be fine. snaps-controllers
should only be used for types in keyring-api
etc, it shouldn't be a problem. snaps-execution-environment
isn't directly in use by the extension at all, as it uses the iframe hosted externally.
Description
Bump snaps packages to latest.
This release adds some under the hood support for a new keyring export. It also adds support for showing SVGs in snaps custom UI.
As part of bumping the packages we had to update TypeScript as well. We had a long-standing patch to TypeScript that could be easily replaced with a small patch to LavaMoat to enable
overrideTaming
. This feature is also set to be enabled in the next version of LavaMoat.