Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump snaps packages #21612

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Bump snaps packages #21612

merged 6 commits into from
Nov 1, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 31, 2023

Description

Bump snaps packages to latest.

Fixes a few small issues and lays the groundwork for exposing links in custom UI.

Does not need additional QA

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Oct 31, 2023
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 31, 2023
@FrederikBolding
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@FrederikBolding FrederikBolding marked this pull request as ready for review November 1, 2023 11:21
@FrederikBolding FrederikBolding requested review from a team as code owners November 1, 2023 11:21
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1754b3d) 68.78% compared to head (5ecf0bb) 68.76%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21612      +/-   ##
===========================================
- Coverage    68.78%   68.76%   -0.02%     
===========================================
  Files         1037     1037              
  Lines        41316    41321       +5     
  Branches     11027    11032       +5     
===========================================
- Hits         28418    28414       -4     
- Misses       12898    12907       +9     
Files Coverage Δ
app/scripts/metamask-controller.js 55.24% <0.00%> (-0.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [5ecf0bb]
Page Load Metrics (1252 ± 370 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8513199116
domContentLoaded6912591147
load8020731252771370
domInteractive6912591147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 376 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 2.68 KiB (0.06%)

@bowensanders
Copy link
Contributor

QA Passes ✅

@FrederikBolding FrederikBolding merged commit 82ceffb into develop Nov 1, 2023
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v15 branch November 1, 2023 21:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants