Create disclaimer view #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
beautiful |
|
@frankiebee agree, you should walk through these commits and make sure they make sense I know you said you wanted to do this one but dan grabbed it on waffle first (actually looks like he forgot to do that on the waffle before he started) |
|
|
SeungjunWe
pushed a commit
to DcentWallet/metamask-extension
that referenced
this pull request
Jul 13, 2020
NW release 4.11.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
Tried to make the commits very chronologically educational for @frankiebee. If you're awake before me, you could try going through them in order to see how I went about this.