E2e appium/add splash animation step (#5748)

* Added waitforsplashanimation steps to feature files * Remove updated values from the ios config file * Remove NetworkFlow background steps and update onboarding steps definition
MetaMask · Feb 10, 2023 · 264a509 · 264a509
1 parent 7a7c5cb
commit 264a509
Show file tree

Hide file tree

Showing 17 changed files with 47 additions and 36 deletions.
diff --git a/wdio.conf.js b/wdio.conf.js
@@ -115,7 +115,7 @@ export const config = {
   baseUrl: 'http://localhost',
   //
   // Default timeout for all waitFor* commands.
-  waitforTimeout: 120000,
+  waitforTimeout: 220000,
   //
   // Default timeout in milliseconds for request
   // if browser driver or grid doesn't send response
@@ -202,7 +202,7 @@ export const config = {
     // <string> (expression) only execute the features or scenarios with tags matching the expression
     tagExpression: '',
     // <number> timeout for step definitions
-    timeout: 210000,
+    timeout: 310000,
     // <boolean> Enable this config to treat undefined definitions as warnings.
     ignoreUndefinedDefinitions: false,
   },

diff --git a/wdio/features/Accounts/CreatingWalletAccount.feature b/wdio/features/Accounts/CreatingWalletAccount.feature
@@ -1,12 +1,12 @@
-@androidApp 
-@ChainScenarios 
+@androidApp
+@ChainScenarios
 @smoke
 
 Feature: Creating account in wallet
 
   Scenario: Import account
-    Given I have imported my wallet
-    # Given I have created my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
 

diff --git a/wdio/features/Accounts/ImportingAccount.feature b/wdio/features/Accounts/ImportingAccount.feature
@@ -5,7 +5,8 @@
 Feature: Importing account in wallet
 
   Scenario: Import account
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
 

diff --git a/wdio/features/AddressFlow.feature b/wdio/features/AddressFlow.feature
@@ -1,16 +1,17 @@
-@androidApp 
-@ChainScenarios 
+@androidApp
+@ChainScenarios
 @regression
 
 Feature: Adding addresses to contacts via address book modal and the contacts screen
   A user should see the correct warning when trying to send funds to a contract address
   A user can saved an ENS name to your address book
-  
+
 
   The contacts you saved on network A does not carry over to network B
 
   Scenario: Import account and navigate to Send
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And On the Main Wallet view I tap "Send"

diff --git a/wdio/features/BrowserFlow/AddFavorite.feature b/wdio/features/BrowserFlow/AddFavorite.feature
@@ -5,7 +5,8 @@ Feature: This feature file covers adding favorite websites in browser.
   Scenario: Adding browser Favorites
     Add, click and delete favorites. Display favorites in the Favorites tab of home.metamask.io
 
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And I navigate to the browser

diff --git a/wdio/features/BrowserFlow/AddressBar.feature b/wdio/features/BrowserFlow/AddressBar.feature
@@ -1,11 +1,12 @@
-@androidApp 
+@androidApp
 @regression
 Feature: This feature file covers address view functionality in the browser.
 
   Scenario: Address bar
     Navigate to websites using browser address bar.
 
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And I navigate to the browser

diff --git a/wdio/features/BrowserFlow/ENSWebsite.feature b/wdio/features/BrowserFlow/ENSWebsite.feature
@@ -4,7 +4,8 @@ Feature: This feature file covers ENS website in browser.
   Scenario: ENS website loads correctly
     Navigate to ENS website using browser address bar.
 
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And I navigate to the browser

diff --git a/wdio/features/BrowserFlow/InvalidURL.feature b/wdio/features/BrowserFlow/InvalidURL.feature
@@ -2,7 +2,8 @@
 Feature: This feature file covers invalid url functionality in the browser.
 
   Scenario: Searching an invalid url and prompts the user with an error message
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And I navigate to the browser

diff --git a/wdio/features/BrowserFlow/NavigationControls.feature b/wdio/features/BrowserFlow/NavigationControls.feature
@@ -5,7 +5,8 @@ Feature: This feature file covers all the navigation control options in browser.
     Use the browser controls at the bottom of the view to go back,
     forward, search, multi-browser tab view and home button.
 
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And I navigate to the browser
@@ -16,7 +17,7 @@ Feature: This feature file covers all the navigation control options in browser.
     Then the browser view is on the "https://www.reddit.com/" website
     And I tap on the back arrow control button
     Then the browser view is on the "https://home.metamask.io/" website
-  
+
     When I tap on browser tab button with count 1
     Then multi browser tab view is displayed
 
@@ -25,4 +26,4 @@ Feature: This feature file covers all the navigation control options in browser.
 
     When I tap on browser tab button with count 2
     And I tap on "Close All" button on multi browser tab view
-    Then all browser tabs are closed
+    Then all browser tabs are closed
diff --git a/wdio/features/BrowserFlow/OptionMenu.feature b/wdio/features/BrowserFlow/OptionMenu.feature
@@ -1,11 +1,12 @@
-@androidApp 
-@ChainScenarios 
+@androidApp
+@ChainScenarios
 @regression
 
 Feature: This feature file covers the option menu in the browser.
 
   Background: The user navigates to the Browser screen
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And I navigate to the browser

diff --git a/wdio/features/BrowserFlow/PhishingDetection.feature b/wdio/features/BrowserFlow/PhishingDetection.feature
@@ -2,7 +2,8 @@
 Feature: This feature file covers phishing detection functionality the browser.
 
   Scenario: Visiting a malicious website prompts the user with the phishing detection warning
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And I navigate to the browser

diff --git a/wdio/features/BrowserFlow/SwitchAccount.feature b/wdio/features/BrowserFlow/SwitchAccount.feature
@@ -5,7 +5,8 @@ Feature: This feature file cover the switch account on the browser flow.
     Use the search bar on the homepage to return a popular defi
     apps as a suggested search, connect to the dapp and then switch accounts
 
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
     And I navigate to the browser
@@ -28,4 +29,4 @@ Feature: This feature file cover the switch account on the browser flow.
     Then the created account is selected
     And "Account 2" is the active wallet account
 
-#And active wallet is connected to Uniswap
+#And active wallet is connected to Uniswap
diff --git a/wdio/features/ExploringWizard.feature b/wdio/features/ExploringWizard.feature
@@ -1,10 +1,11 @@
-@androidApp 
+@androidApp
 @regression
 
 Feature: Exploring wizard
 
   Scenario: A user should be able to go through the start exploring tutorial
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And the onboarding wizard is visible on wallet view
 
@@ -54,7 +55,8 @@ Feature: Exploring wizard
     And the "Skip" button is no longer visible
 
   Scenario: A user should be able to tap the Skip button and the onboarding tutorial modal should disappear
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And the onboarding wizard is visible on wallet view
 

diff --git a/wdio/features/ImportCustomToken.feature b/wdio/features/ImportCustomToken.feature
@@ -5,7 +5,8 @@
 Feature: Adding a custom token to your wallet
 
   Scenario: Import account
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
 

diff --git a/wdio/features/LockResetWallet.feature b/wdio/features/LockResetWallet.feature
@@ -5,7 +5,8 @@
 Feature: Lock and Reset Wallet
 
   Scenario: Import account
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
 

diff --git a/wdio/features/NetworkFlow.feature b/wdio/features/NetworkFlow.feature
@@ -5,13 +5,10 @@
 Feature: Adding Networks via the popular and custom networks flow
   A user should be able to add a custom network via the popular network flow
   A user should also have the ability to a add custom network via the custom network flow.
-  Background: Import wallet
-    Given I have imported my wallet
-    And I tap No Thanks on the Enable security check screen
-    And I tap No thanks on the onboarding welcome tutorial
 
   Scenario Outline: Adding a network via the new popular network flow
-    Given I have imported my wallet
+    Given the app displayed the splash animation
+    And I have imported my wallet
     And I tap No Thanks on the Enable security check screen
     And I tap No thanks on the onboarding welcome tutorial
 

diff --git a/wdio/step-definitions/onboarding.steps.js b/wdio/step-definitions/onboarding.steps.js
@@ -22,7 +22,7 @@ Then(/^"([^"]*)?" is displayed/, async (text) => {
   switch (text) {
     case 'METAMASK':
       await WelcomeScreen.waitForSplashAnimationToDisplay();
-      await WelcomeScreen.waitForSplashAnimationToDisappear();
+      await WelcomeScreen.waitForSplashAnimationToNotExit();
       break;
     case 'Wallet setup':
       await OnboardingScreen.isScreenTitleVisible();