Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e start exploring flow #5293

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Conversation

SamuelSalas
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@SamuelSalas SamuelSalas requested a review from a team as a code owner November 24, 2022 16:53
@cortisiko cortisiko added Appium needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 29, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamuelSalas I left a few comments. Outside of that everything looks good in my opinion.

wdio/features/step-definitions/start-exploring.js Outdated Show resolved Hide resolved
wdio/features/step-definitions/start-exploring.js Outdated Show resolved Hide resolved
wdio/features/step-definitions/start-exploring.js Outdated Show resolved Hide resolved
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review comments

wdio/features/step-definitions/start-exploring.js Outdated Show resolved Hide resolved
wdio/features/step-definitions/start-exploring.js Outdated Show resolved Hide resolved
wdio/features/helpers/Gestures.js Outdated Show resolved Hide resolved
wdio/features/StartExploring.feature Outdated Show resolved Hide resolved
wdio/features/step-definitions/start-exploring.js Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelSalas SamuelSalas merged commit e29a423 into main Nov 30, 2022
@SamuelSalas SamuelSalas deleted the e2e-test/start-exploring-flow branch November 30, 2022 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants