-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Create detectSnapLocation method to install a Local Snap #5923
[FEATURE] Create detectSnapLocation method to install a Local Snap #5923
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending task to do on follow up PR,
- Add testing to,
-
app/core/Snaps/location/fetch.ts
-
app/core/Snaps/location/http.ts
-
app/core/Snaps/location/local.ts
-
app/core/Snaps/location/location.ts
-
- Remove
app/util/snaps/fetchNPMPackage.ts
if its not necessary anymore
LGTM. Solve conflicts and merge
e3f5191
to
3db8c1d
Compare
6536f3e
to
61387b0
Compare
3278bf3
to
7647226
Compare
Issue for creating unit test: https://app.zenhub.com/workspaces/key-management-team-62505028c3853700162f65e0/issues/gh/metamask/mobile-planning/730 |
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
detectSnapLocation
and passes the fetch function to itScreenshots/Recordings
Screen.Recording.2023-03-07.at.4.12.02.PM.mov
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/504
Checklist