[Feature] Install snap from dapp iOS #6002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
owencraston
force-pushed
the
detectSnapLocation-npm
branch
2 times, most recently
from
23da343 to
dce223a
Compare
Base automatically changed from
detectSnapLocation-npm
to
feat/snaps-system-integration
March 23, 2023 23:20
owencraston
force-pushed
the
install-snap-from-dapp
branch
4 times, most recently
from
ad810c0 to
c283cc2
Compare
owencraston
changed the title
gantunesr
reviewed
Mar 24, 2023
- extract icon from tar file - show request permissions for install snap and account access - move snap webview to the root of the app and make it invisible - create RPC method handlers to register snaps rpc methods
owencraston
force-pushed
the
install-snap-from-dapp
branch
from
e66cb41 to
5073843
Compare
owencraston
added
mobile-snaps
No QA Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
Screen.Recording.2023-03-23.at.10.50.52.PM.mov
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/618
Checklist