[Flask] bitrise pipelines #6645
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.0.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,16 @@ pipelines: | |
| stages: | ||
| - run_smoke_e2e_ios_android_stage: {} | ||
| - notify: {} | ||
| # Pipeline for Flask | ||
| create_flask_release_builds_pipeline: | ||
| stages: | ||
| - create_build_flask_release: {} | ||
| - notify: {} | ||
| release_flask_builds_to_store_pipeline: | ||
| stages: | ||
| - create_build_flask_release: {} | ||
| - deploy_flask_build_release: {} | ||
| - release_notify: {} | ||
|
|
||
| #Stages refrence workflows. Those workflows cannot but utility "_this-is-a-utility" | ||
| stages: | ||
|
|
@@ -106,6 +116,15 @@ stages: | |
| release_notify: | ||
| workflows: | ||
| - release_announcing_stores: {} | ||
| create_build_flask_release: | ||
| workflows: | ||
| - build_android_flask_release: {} | ||
| - build_ios_flask_release: {} | ||
| deploy_flask_build_release: | ||
| workflows: | ||
| # Once service connection is established we can use this workflow to deploy to stores | ||
| # - deploy_android_to_store: {} | ||
| - deploy_ios_to_store: {} | ||
| workflows: | ||
| # Code Setups | ||
| setup: | ||
|
|
@@ -202,7 +221,7 @@ workflows: | |
| - yarn@0: | ||
| inputs: | ||
| - command: build:announce | ||
| title: Announcing pre-release | ||
NicolasMassart marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| is_always_run: false | ||
| meta: | ||
| bitrise.io: | ||
|
|
@@ -671,6 +690,115 @@ workflows: | |
| - pipeline_intermediate_files: sourcemaps/ios/index.js.map:BITRISE_APP_STORE_SOURCEMAP_PATH | ||
| - deploy_path: sourcemaps/ios/index.js.map | ||
| title: Deploy Source Map | ||
| build_ios_flask_release: | ||
|
There was a problem hiding this comment. C: I wonder if we have a way to prevent duplication of these big yaml blocks and just have one called with params. they really mostly look the same. There was a problem hiding this comment. @NicolasMassart regarding the sourcemap comment, yes they will be different. I am wondering if I need to change the sourcemap logic since it is failing on bitrise |
||
| before_run: | ||
| - code_setup | ||
| after_run: | ||
| - _notify_failure_on_slack | ||
| steps: | ||
| - certificate-and-profile-installer@1: {} | ||
| - set-xcode-build-number@1: | ||
| inputs: | ||
| - build_short_version_string: $FLASK_VERSION_NAME | ||
| - build_version: $FLASK_VERSION_NUMBER | ||
| - plist_path: $PROJECT_LOCATION_IOS/MetaMask/MetaMask-Flask-Info.plist | ||
| - cocoapods-install@2: {} | ||
| - script@1: | ||
| inputs: | ||
| - content: |- | ||
| #!/usr/bin/env bash | ||
| node -v | ||
| METAMASK_BUILD_TYPE=flask METAMASK_ENVIRONMENT='production' yarn build:ios:pre-flask | ||
| title: iOS Sourcemaps & Build | ||
| is_always_run: false | ||
| - [email protected]: | ||
| is_always_run: false | ||
| is_skippable: true | ||
| inputs: | ||
| - pipeline_intermediate_files: ios/build/output/MetaMask-Flask.ipa:BITRISE_APP_STORE_IPA_PATH | ||
| - deploy_path: ios/build/output/MetaMask-Flask.ipa | ||
| title: Deploy iOS IPA | ||
| - [email protected]: | ||
sethkfman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| is_always_run: false | ||
| is_skippable: true | ||
| inputs: | ||
| - deploy_path: ios/build/MetaMask-Flask.xcarchive:BITRISE_APP_STORE_XCARCHIVE_PATH | ||
| title: Deploy Symbols File | ||
| - [email protected]: | ||
| is_always_run: false | ||
| is_skippable: true | ||
| inputs: | ||
| - pipeline_intermediate_files: sourcemaps/ios/index.js.map:BITRISE_APP_STORE_SOURCEMAP_PATH | ||
| - deploy_path: sourcemaps/ios/index.js.map | ||
| title: Deploy Source Map | ||
| build_android_flask_release: | ||
| before_run: | ||
| - code_setup | ||
| after_run: | ||
| - _notify_failure_on_slack | ||
| steps: | ||
| - change-android-versioncode-and-versionname@1: | ||
| inputs: | ||
| - new_version_name: $FLASK_VERSION_NAME | ||
| - new_version_code: $FLASK_VERSION_NUMBER | ||
| - build_gradle_path: $PROJECT_LOCATION_ANDROID/app/build.gradle | ||
| - file-downloader@1: | ||
| inputs: | ||
| - source: $BITRISEIO_ANDROID_FLASK_KEYSTORE_URL | ||
| - destination: android/keystores/flaskRelease.keystore | ||
| - restore-gradle-cache@1: {} | ||
| - install-missing-android-tools@2: | ||
| inputs: | ||
| - ndk_revision: $NDK_VERSION | ||
| - gradlew_path: $PROJECT_LOCATION/gradlew | ||
| - script@1: | ||
| inputs: | ||
| - content: |- | ||
| #!/usr/bin/env bash | ||
| node -v | ||
| METAMASK_BUILD_TYPE=flask METAMASK_ENVIRONMENT='production' yarn build:android:pre-release:bundle:flask | ||
| title: Build Android Pre-Release Bundle | ||
| is_always_run: false | ||
| - save-gradle-cache@1: {} | ||
| - [email protected]: | ||
| is_always_run: false | ||
| is_skippable: true | ||
| inputs: | ||
| - pipeline_intermediate_files: $PROJECT_LOCATION/app/build/outputs/apk/flask/release/app-flask-release.apk:BITRISE_PLAY_STORE_APK_PATH | ||
sethkfman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - deploy_path: $PROJECT_LOCATION/app/build/outputs/apk/flask/release/app-flask-release.apk | ||
| title: Bitrise Deploy APK | ||
| - [email protected]: | ||
| is_always_run: false | ||
| is_skippable: true | ||
| inputs: | ||
| - pipeline_intermediate_files: $PROJECT_LOCATION/app/build/outputs/apk/flask/release/sha512sums.txt:BITRISE_PLAY_STORE_SHA512SUMS_PATH | ||
| - deploy_path: $PROJECT_LOCATION/app/build/outputs/apk/flask/release/sha512sums.txt | ||
| title: Bitrise Deploy Checksum | ||
| - [email protected]: | ||
| is_always_run: false | ||
| is_skippable: true | ||
| inputs: | ||
| - pipeline_intermediate_files: $PROJECT_LOCATION/app/build/outputs/mapping/flaskRelease/mapping.txt:BITRISE_PLAY_STORE_MAPPING_PATH | ||
| - deploy_path: $PROJECT_LOCATION/app/build/outputs/mapping/flaskRelease/mapping.txt | ||
| title: Bitrise ProGuard Map Files | ||
| - [email protected]: | ||
| is_always_run: false | ||
| is_skippable: true | ||
| inputs: | ||
| - pipeline_intermediate_files: $PROJECT_LOCATION/app/build/outputs/bundle/flaskRelease/app-flask-release.aab:BITRISE_PLAY_STORE_ABB_PATH | ||
| - deploy_path: $PROJECT_LOCATION/app/build/outputs/bundle/flaskRelease/app-flask-release.aab | ||
| title: Bitrise Deploy AAB | ||
| - [email protected]: | ||
| is_always_run: false | ||
| is_skippable: true | ||
| inputs: | ||
| - pipeline_intermediate_files: /bitrise/src/sourcemaps/android/index.js.map:BITRISE_PLAY_STORE_SOURCEMAP_PATH | ||
sethkfman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - deploy_path: sourcemaps/android/index.js.map | ||
| title: Bitrise Deploy Sourcemaps | ||
| meta: | ||
| bitrise.io: | ||
| stack: linux-docker-android-20.04 | ||
| machine_type_id: elite-xl | ||
| app: | ||
| envs: | ||
| - opts: | ||
|
|
@@ -706,6 +834,12 @@ app: | |
| - opts: | ||
| is_expand: false | ||
| VERSION_NUMBER: 1126 | ||
| - opts: | ||
| is_expand: false | ||
| FLASK_VERSION_NAME: 0.0.1 | ||
| - opts: | ||
| is_expand: false | ||
| FLASK_VERSION_NUMBER: 1 | ||
| - opts: | ||
| is_expand: false | ||
| ANDROID_APK_LINK: '' | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests with explicit output and comments? This thing is getting out of hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On extension we found it easier to disable Sentry entirely in development builds (see https://github.com/MetaMask/metamask-extension/blob/230c0c6fa1626bc1afd68c22321f5c166425dd12/app/scripts/lib/setupSentry.js#L88). Most of our Sentry testing was done with QA or production-like builds as part of regression testing. On the rare occasion that we wanted to test Sentry with a development build, it's easy to comment out that line.
That would reduce this condition to a single ternary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we wanted to go that route here, and disable Sentry for development builds, that would be simpler to do in a separate PR. Better to keep this one focused if we can.
A more direct solution to cleaning this up for now would be to split this into two steps: determine the environment, then the sentry environment. e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have went ahead and modified this logic to live inside a function I am calling
deriveSentryEnvironment.This function is well tested in the new
sentryUtils.test.tsfile. I opted to not split up the meta mask environment and sentry environment to keep continuity with what we have already published in sentry. what would be the use case for having a separatemetamaskEnvironmentif we don't log it in sentry?