-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile snaps] Update snaps packages to version 2.0.2 #7609
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected] |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
c436d48
to
8c7e747
Compare
10d0af6
to
c01a66f
Compare
8c7e747
to
2e82b71
Compare
38435d8
to
c39f538
Compare
c39f538
to
cf7287b
Compare
- fist request comes in as wallet_requestPermissions - upon approval we then handle the wallet_installSnap request
a2cee87
to
75885d5
Compare
@SocketSecurity ignore @metamask/[email protected] |
@SocketSecurity ignore @metamask/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job and well structure code.
Description
Update snaps controller to version 2.0.2.
This also involved updating some of the peer dependancies such as
@metamask/slip44
,@metamask/snaps-utils"
,@metamask/rpc-methods
.Updated the snaps permissions titles to include the newer permissions. The list of permissions can be found here.
This changed how snap are installed now...
Before:
wallet_installSnap
approval. From this point we would parse the approval request data to show the requested permissions. We would then handle the install state internally.Now:
wallet_requestPermissions
approval type. For this we show theInstallSnapConnectionRequest
. Approving this triggers a second approval request of typewallet_installSnap
. This is where we show the requested permissions inside theInstallSnapPermissionsRequest
. Once approved we show a success/error screenSince the install logic relies so heavily on the the
useApprovalRequest
response, I moved all of the install logic fromapp/components/UI/...
intoapp/components/Approvals/InstallSnapApproval
Related issues
Progresses: https://github.com/MetaMask/accounts-planning/issues/116
Fixes: https://github.com/MetaMask/accounts-planning/issues/115
Fixes: https://github.com/MetaMask/accounts-planning/issues/114
Manual testing steps
yarn setup
Screenshots/Recordings
Screen.Recording.2023-11-06.at.11.39.25.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist