Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before :
this change we needed to disable shasum validation on snaps. The reason for this was due to the fact that my custom RnTar native module was reading the parsed snap code by line. This lead to small differences in the output file that differed from the npm source code. The result was that the computed shasum would be different that the one present in the manifest and woulld fail to install.
Now:
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/952
Manual testing steps
yarn setup
start:android
Screenshots/Recordings
Screen.Recording.2023-11-10.at.10.07.19.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist