Position v3 (Dynamic position) #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
codewithgun
force-pushed
the
feat/dynamic-position
branch
from
a0c7262 to
90f1968
Compare
Closed
codewithgun
force-pushed
the
feat/dynamic-position
branch
9 times, most recently
from
1b89b2d to
a7dde02
Compare
codewithgun
force-pushed
the
feat/dynamic-position
branch
2 times, most recently
from
94e8345 to
83c2a05
Compare
codewithgun
force-pushed
the
feat/dynamic-position
branch
from
51aff30 to
facad74
Compare
| - `getPairPubkeyIfExists` added new `baseFeePowerFactor` parameter | ||
| - `getAllPresetParameters` now return `presetParameter` and `presetParameter2` accounts instead of only `presetParameter` | ||
| - Rename `LBCLMM_PROGRAM_IDS` to `DLMM_PROGRAM_IDS` | ||
| - `createPermissionLbPair` added new `protocolFeeBps` parameter |
There was a problem hiding this comment.
do we need this function in sdk? caused it is only used by admin
|
|
||
| ### Added | ||
|
|
||
| - Admin function `initialize_token_badge` to initialize token badge for token 2022 |
There was a problem hiding this comment.
Was thinking to stop support rust cli in the program repo. This will be the main version moving forward.
| } | ||
|
|
||
| #[derive(Parser, Debug)] | ||
| pub struct DownloadUserPoolFilesParams { |
There was a problem hiding this comment.
Why we need this function?
There was a problem hiding this comment.
Not needed. But putting it just for this PR to allow reviewer able to dump and run the test personally for v2 to v3 (dynamic position) test. Will remove it in next PR.
The test is here
codewithgun
force-pushed
the
feat/dynamic-position
branch
2 times, most recently
from
f474a7e to
a845e4d
Compare
codewithgun
force-pushed
the
feat/dynamic-position
branch
from
02320c9 to
0cb73dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.