General | Add support for F2FS and Btrfs root file systems #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
MichaIng
commented
Mar 2, 2021
MichaIng
commented
- DietPi-FS_partition_resize | Add support for F2FS file system expansion
- DietPi-FS_partition_resize | Since all known systems require the root/boot file system to be as a partition on a partition table, do not support cases the it is not on a partition, but instead error out with "unsupported naming scheme". Even if there were cases where such was possible, it's better to create visible failure for now. If such cases were reported, we'd need to handle those gracefully at many other places in the code.
- DietPi-FS_partition_resize | Use "set -e" to error our directly when any command fails. This requires to use either if-then-else or "a || b" for conditionals, so that the check itself does not error out the script.
+ DietPi-FS_partition_resize | Add support for F2FS file system expansion + DietPi-FS_partition_resize | Since all known systems require the root/boot file system to be as a partition on a partition table, do not support cases the it is not on a partition, but instead error out with "unsupported naming scheme". Even if there were cases where such was possible, it's better to create visible failure for now. If such cases were reported, we'd need to handle those gracefully at many other places in the code. + DietPi-FS_partition_resize | Use "set -e" to error our directly when any command fails. This requires to use either if-then-else or "a || b" for conditionals, so that the check itself does not error out the script.
MichaIng
changed the title
+ DietPi-Drive_Manager | Add support for XFS format and fsck + DietPi-Drive_Manager | Add support for F2FS and Btrfs resize + DietPi-Drive_Manager | To collect drive info, consequently use findmnt for mounted drives and lsblk for unmounted drives. Keep using blkid only to get the list of formatted filesystems, since lsblk prints parent drives and unformatted drives as well. + DietPi-Drive_Manager | Harden and error handle a few steps + DietPi-Drive_Manager | Minor spelling: "Btrfs", "ext4" and "filesystem" which is correct as well and probably more common without space.
+ DietPi-Drive_Manager | Unmount drive automatically on format, so that it does not need to be unmounted manually. Use Unmount_Drive function, so that the mount point directory is removed as well. + DietPi-Drive_Manager | Unmount drive and stop service on fsck after a supported filesystem type has been detected to minimise the cases where services are stopped unnecessarily.
|
ToDo:
The more I work with with F2FS and Btrfs I appreciate the flexibility when managing ext4 (whether it's about file system limitations or limited userspace tool features), especially as rootfs 😄. |
+ DietPi-Drive_Manager | After fsck, remount affected drive only, and do it and swapon only if it was mounted before. "mount -a" only works for drives without "noauto", hence root, boot and tmpfs mounts by default on DietPi. For this reason, the "mount -a" on each drive scan loop is obsolete as well.
+ DietPi-Drive_Manager | Do not unmount ext4 filesystems on resize, as it is not required and might break concurrent usage. Otherwise we would need to warn and ask first that the drive will be unmounted temporarily. + DietPi-Drive_Manager | Do not unmount F2FS filesystems on resize, but only remount them as R/O if not already the case, so at least concurrent read access remains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.