Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General | Replace unsupported SBC IDs with generic SoC IDs #4193

Merged
merged 11 commits into from
Mar 13, 2021

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented Mar 12, 2021

Status: Review

Commit list/description:
We still list hardware IDs for SBCs which were removed long time ago. Since we do not expect or ship a reference image/pre-image, we cannot know whether our tweaks for those models are still valid or not. The only relevant and valid info about those models is the SoC ID, if we have one for it. So I decided to finally remove those IDs and instead add generic hardware IDs for each SoC we have a dedicated SoC ID for. This assures that no outdated/invalid tweaks are applied or assumptions are done and on the other hand adds a basic support for a lot mot SBCs which use known SoCs, relevant e.g. to know which GPU it runs, or for onboard capabilities.

Also while updating our images, I recognised that there is no single Firefly RK3399 user anymore, even that it is now available as stable image for a longer time already. So I removed it as well in favour if a generic RK3399 ID.

Affected devices are migrated with next update automatically. In some cases, where we do not have an SoC ID, those will be migrated to the fallback "Generic Device" (ID=22). We need to document the change well so that no confusion is created, especially that it does not "reduce" support for those SBCs but reduces the risk for wrong assumptions and wrong tweaks being applied.

+ DietPi-Obtain_HW_model | Remove unsupported SBC models and instead add generic SoC-specific models where we provide and use an SoC ID for.
@MichaIng MichaIng added this to the v7.1 milestone Mar 12, 2021
+ DietPi-Patch | Update changed hardware IDs before dietpi-obtain_hw_model would reset them to 22
+ DietPi-Patch | Remove obsolete v6.-1 patches, which were only required for a small number of the very first v6.0 images, auto-updated to v6.0 on first boot.
+ DietPi-PREP | Replace unsupported SBC IDs with generic SoC IDs
+ DietPi-Survey_report | Add support for generic SoC hardware IDs
+ DietPi-PREP | Remove tweaks for removed hardware models. Those are very old and we have no chance to verify whether they are still required or not without providing and assuming a base image/kernel.
+ DietPi-Set_hardware | Remove code for removed hardware IDs
+ DietPi-Config | Remove code for removed hardware IDs
+ DietPi-Set_hardware | Remove obsolete code
+ DietPi-Software | Remove code for removed hardware IDs
@MichaIng MichaIng marked this pull request as ready for review March 12, 2021 15:28
+ DietPi-Patches | Replace removed hardware IDs with new generic SoC IDs
MichaIng added a commit to MichaIng/DietPi-Docs that referenced this pull request Mar 12, 2021
MichaIng added a commit to MichaIng/DietPi-Website that referenced this pull request Mar 12, 2021
@MichaIng MichaIng linked an issue Mar 12, 2021 that may be closed by this pull request
@MichaIng MichaIng mentioned this pull request Mar 12, 2021
Joulinar
Joulinar previously approved these changes Mar 12, 2021
ravenclaw900
ravenclaw900 previously approved these changes Mar 13, 2021
+ CHANGELOG | Add a detailed entry about the removed/unsupported SBC models
+ CHANGELOG | Fix location of the DietPi-Drive_Manager loop device fix
@MichaIng MichaIng dismissed stale reviews from ravenclaw900 and Joulinar via 17a5952 March 13, 2021 15:55
@MichaIng MichaIng merged commit e8751e3 into dev Mar 13, 2021
@MichaIng MichaIng deleted the hardware_models branch March 13, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orange Pi One Plus
3 participants