-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General | Replace unsupported SBC IDs with generic SoC IDs #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaIng
added a commit
to MichaIng/DietPi-Docs
that referenced
this pull request
Mar 12, 2021
MichaIng
added a commit
to MichaIng/DietPi-Website
that referenced
this pull request
Mar 12, 2021
Closed
Closed
Joulinar
previously approved these changes
Mar 12, 2021
ravenclaw900
previously approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Review
Commit list/description:
We still list hardware IDs for SBCs which were removed long time ago. Since we do not expect or ship a reference image/pre-image, we cannot know whether our tweaks for those models are still valid or not. The only relevant and valid info about those models is the SoC ID, if we have one for it. So I decided to finally remove those IDs and instead add generic hardware IDs for each SoC we have a dedicated SoC ID for. This assures that no outdated/invalid tweaks are applied or assumptions are done and on the other hand adds a basic support for a lot mot SBCs which use known SoCs, relevant e.g. to know which GPU it runs, or for onboard capabilities.
Also while updating our images, I recognised that there is no single Firefly RK3399 user anymore, even that it is now available as stable image for a longer time already. So I removed it as well in favour if a generic RK3399 ID.
Affected devices are migrated with next update automatically. In some cases, where we do not have an SoC ID, those will be migrated to the fallback "Generic Device" (ID=22). We need to document the change well so that no confusion is created, especially that it does not "reduce" support for those SBCs but reduces the risk for wrong assumptions and wrong tweaks being applied.