DietPi-Software | Part 2: Merge "Optimised" and "Additional" software menus #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not yet sure how to show it best in the menu. We have the "Select Software" separator, so "Software selection" somehow seems doubled. "Search" and "List", "Select from List", or "Search Software" and "Select Software" and adjusting the separator a bit? Of course the right-sided text can also contain info about it, but IMO the word(s) at the left side should be as clear as possible. |
+ DietPi-Software | Rename "Software selection" menu entry to "Browse", and adjust description + DietPi-Software | Move systemd-logind umask into Run_Installations() function, where pending install states (=1) are still present, else checking for Kodi install is done wrong. + DietPi-Software | Print "Installation completed" message before uploading survey, as a failure in DietPi-Survey has no effect on the completed install. + DietPi-Software | Update No-IP docs link + DietPi-Software | Minor code reordering and code comment updates
|
Went with: Feedback and suggestions are still welcome, but I'll merge this now to go on with "part 3". |
|
what about |
|
I like that, adding it to the Go PR. |
MichaIng
added a commit
that referenced
this pull request
Apr 15, 2021
+ DietPi-Software | Main menu entry renaming: #4270 (comment)
MichaIng
added a commit
that referenced
this pull request
Apr 16, 2021
+ DietPi-Software | Make Go an own install option (ID=188) + DietPi-Patches | Mark now dedicated Go as installed if OpenBazaar is + DietPi-Patches | Load DietPi-Globals at the beginning of the script now and implement G_EXEC error handler where applicable + DietPi-Software | Go: Grab latest available version automatically from JSON version of the download page + DietPi-Software | Go: Add a note to uninstall section about keeping GOPATH /mnt/dietpi_userdata/go + DietPi-Software | Main menu entry renaming: #4270 (comment) + DietPi-Software | Go: Since Go v1.16, GOPATH vs module mode is not auto-detected anymore by default, but module mode is forced. Since we want to install and control package instances in our defined GOPATH, revert this change via /etc/bashrc.d/go.sh for bash shell sessions, so that the presence of a go.mod file in cwd triggers module mode, while otherwise GOPATH is used: https://golang.org/ref/mod#mod-commands + DietPi-Software | OpenBazaar: Add documentation URL to systemd unit and assure it starts after network is up to allow IP binding + DietPi-Software | OpenBazaar: Error-handle init and credentials input, as e.g. when not being able to confirm/repeat the password, there is no clean way to retry: CTRL+C terminates the attempt, but leaves the instance without credentials set and more importantly it leaves the terminal in a broken state, manipulated by OB to hide the typed password and not reset on regular termination, which is bad. Piping the output through "tee" via G_EXEC_OUTPUT=1 limits the terminal manipulation to the tee instance, so exiting or retrying can be done fine. + DietPi-Software | YaCy: Detect latest version automatically, using a similar method as with OpenBazaar + DietPi-Software | YaCy: Start enabled service after network, to allow IP binding, and add official Wiki to systemd documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Review
The separation between "additional" software and "optimised" software did never follow any consistent rule:
The problem with the separation is that especially development environments are degraded in a way, while we want to have programming languages, runtime environments, their packaging tools in case and such more prominent, to better target developers as well. The list becomes longer, but the "optimised" list was very long already, while the "additional" list was quite short, so merging them does not increase the list significantly, and of course to cover this, we added the search option.
The software titles from the additional list mostly have no description and no docs URLs, hence this would need to be added. Also we can think about restructuring the categories, but for now at least nothing really conflicts, so no urgent change required IMO.
Commit list/description: