-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-Software | VSCodium #4276
Conversation
Well, that was simple. |
Lol a pretty simple naked install, but that is all fine when the package-contained setup is good. Good to have this as an alternative to VSCode after #4083. |
and the good thing, version provided via From install test on GitHub same version |
Please try to install/enable dbus:
EDIT: Ah no that cannot be the reason as it's installed and enabled automatically with all desktop installs. |
It looks like |
When I try to sign into GitHub from VSCodium, in that status bar, it shows "Signing in to github.com..." forever, while it should show a login prompt, as far as I understand. I was thinking that it might be due to missing default browser, but making Firefox the default browser doesn't change anything 🤔. Btw, we should add the application icon to the desktop? EDIT: Tried to install |
You would need to click on |
Ahhh, I didn't recognised that at the top. |
You don't have the error message at the bottom? |
Nope. |
Hmm I need to do another test. Which extension you used? |
The official GitHub PR and Issues extension. I'll retry to be sure. |
Okay, it was still required on a fresh setup. I think that daemon is needed to create a new keyring with credentials, while accessing an existing one does not require it, or so. I'm not sure whether there is an alternative to that package, other issues indicate it, but I couldn't find one when searching packages with -keyring ending at least. Shall we add it by default or add a note to the docs instead? The package is small, but it's an additional daemon/process running. |
depends on what people will use it for. I guess this is dedicated to GitHub? Or does it might be related to other plugins as well? |
I think that it would probably be best to add it, as you will probably need it for signing in to Microsoft accounts as well. However, we could probably configure the keychain automatically with the global software password. |
I guess so. Cannot imagine that this extension uses its very own credentials/authentication method but that it's an API of codium that is use by other extensions as well. |
+ DietPi-Software | VSCodium: Install gnome-keyring as dependency, as at least extensions use it to store credentials. It's a backend daemon for the "Secrets API" and there is not really an alternative available, currently: https://freedesktop.org/wiki/Specifications/secret-storage-spec/
Little research, Good to know about this in general, as other desktop applications might use that API as well to store or receive passwords, and also good to know that this is a central storage, hence you do not only trust the application like VSCodium here (which stores the master password) to safely store your GitHub token or other credentials but the Gnome keyring and API developers as well. Usually not relevant, but quite an important details for security enthusiasts 😉. |
Hm, bash doesn't seem to be expanding the second |
Hmm , generally works fine here:
I'll try it with VSCodium uninstall as well. |
As a comparison:
I'll try with a fresh VM. |
Ah yes of course. Taking the glob literal is basically part of the expansion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to approve the PR from inside vscodium
Status: Ready
Reference: #4267
Commit list/description: