DietPi-Software | Webmin: Add support for internal restart #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ DietPi-Software | Webmin: Add support for internal restart by not letting the systemd unit guessing the main process ID anymore. Webmin spawns a new process, if a settings change triggers a restart internally, which makes systemd kill the whole control group, as the original process, guessed as main process, is not running anymore. With this change, there is no main process and systemd will only see the service as "exited" when all processes of the control group are dead. This way no automatic restart loop is required. + DietPi-Software | Webmin: Enable service reload via new (?) reload executable + DietPi-Software | Docker: The official APT repository has now a Bullseye suite, hence use it + DietPi-Software | Align code and comments when 3rd party repositories are used
MichaIng
changed the title
This was referenced May 22, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready
Testing:
Commit list/description: