Support Configuration Hot Reloading #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo: consider refactor to use channel instead of function pointer
|
Libyears is 3.45 |
|
Code coverage is 89.1% |
|
Libyears is 2.42 |
|
Libyears is 2.42 |
|
Code coverage is 89.1% |
1 similar comment
|
Code coverage is 89.1% |
Michad
commented
Nov 28, 2024
internal/server/tile_handler.go
Outdated
| @@ -70,9 +73,21 @@ func newTileHandler(handler defaultHandler) (tileHandler, error) { | |||
| }, errors.Join(err1, err2, err3, err4) | |||
| } | |||
|
|
|||
| func (h *tileHandler) reloadEntities(newEntities reloadableEntities) { | |||
| slog.WarnContext(pkg.BackgroundContext(), "Requesting to refresh entities from configuration") | |||
| h.mux.Lock() | |||
There was a problem hiding this comment.
Do I really need this mutex? I put it in thinking I'd need to do multiple setters but given it ended up being just one, that should be atomic right?
|
Libyears is 2.42 |
|
Code coverage is 89.1% |
|
Libyears is 2.42 |
Michad
force-pushed
the
config-reload-198
branch
from
7199ffb to
ac7f4c2
Compare
|
Libyears is 2.42 |
|
Code coverage is 89.1% |
1 similar comment
|
Code coverage is 89.1% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #198
Adds a new CLI flag when running serve command to enable hot reloading of configuration whenever the file changes. Relies on viper's wrapper for fsnotify hooks so doesn't yet support etcd/other remote providers. Includes documentation of what can be reloaded. Limited to the main tile serve endpoint.