revert to daemons listening to 127.0.0.1 by default

clients can not connect to `0.0.0.0` on windows.
Michael-J-Ward · Apr 16, 2024 · 4af82a4 · 4af82a4
1 parent 1ba763c
commit 4af82a4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/binaries/cli/src/main.rs b/binaries/cli/src/main.rs
@@ -107,7 +107,7 @@ enum Command {
         #[clap(long)]
         machine_id: Option<String>,
         #[clap(long, default_value_t = SocketAddr::new(
-            IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0)), 0)
+            IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 0)
         )]
         bind: SocketAddr,
         #[clap(long)]

diff --git a/binaries/daemon/src/inter_daemon.rs b/binaries/daemon/src/inter_daemon.rs
@@ -75,6 +75,7 @@ pub async fn spawn_listener_loop(
         .local_addr()
         .wrap_err("failed to get local addr of socket")?;
 
+    tracing::debug!("inter-daemon listener starting for machine `{machine_id}` on {socket_addr}");
     tokio::spawn(async move {
         listener_loop(socket, events_tx).await;
         tracing::debug!("inter-daemon listener loop finished for machine `{machine_id}`");

diff --git a/examples/multiple-daemons/run.rs b/examples/multiple-daemons/run.rs
@@ -35,7 +35,7 @@ async fn main() -> eyre::Result<()> {
 
     let (coordinator_events_tx, coordinator_events_rx) = mpsc::channel(1);
     let coordinator_bind = SocketAddr::new(
-        IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0)),
+        IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)),
         DORA_COORDINATOR_PORT_DEFAULT,
     );
     let (coordinator_addr, coordinator) =