-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest JDK distribution by AdoptOpenJDK #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflow looks ok. But with some nits in TS files, single quotes are still used, looks it hasn't been guarded well.
Single quote now only appears in webpack.config.js, which is out of the scope of ts. |
This is to provide more JDK options for users to choose.
OS and architecture are automatically detected.